[5.5][ConstraintSystem] Don't record a mismatch for synthesized arguments #37790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without context synthesized argument would be inferred as a hole, so let's not record any additional fixes for it if there is no way to infer it properly from a parameter (which could also be a hole if it is a generic parameter type). Resolves: rdar://78781552 (cherry picked from commit 9e54006)
|
@swift-ci please test |
airspeedswift
approved these changes
Jun 4, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #37778
Fixes a crash in type-checker when solver attempts to fix structural problems in synthesized arguments.
Without context synthesized argument would be inferred as a hole,
so let's not record any additional fixes for it if there is no way
to infer it properly from a parameter (which could also be a hole
if it is a generic parameter type).
Scope: Invalid expressions with synthesized arguments (inferred as holes) that also have structural issues due
to generic parameters (part of parameter type) being inferred based from other arguments.
Main Branch PR: [ConstraintSystem] Don't record a mismatch for synthesized arguments #37778
Resolves: rdar://78781552
Risk: Low
Reviewed By: @hborla
Testing: Regression tests added to the suite
Resolves: rdar://78781552
(cherry picked from commit 9e54006)