Fix CastOptimizer for guaranteed values while handling checked_cast_br #37800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Build failed |
|
@swift-ci test Linux platform |
|
In the interest of avoiding extra borrow scopes, I think we can replace the checked-cast's block argument (its terminator result) with the newly cast value instead of creating a degenerate phi. |
|
@swift-ci test |
|
Build failed |
|
@swift-ci test Linux platform |
Fixes rdar://77684045. The rdar is about a SILVerifier assert for SIL created by cast optimizer, where a guaranteed op of checked_cast_br iis transformed to an op of a phi argument without creating borrow scope. Fix: During cast optimization, when the direction of checked_cast_br can be determined statically, replace the success/failure value in the destination block and create an unconditional branch to the destination block. This is done only in OSSA, since we ban critical edges.
|
@swift-ci smoke test |
|
@atrick Sorry for the delay on this. I have fixed it by getting rid of the unnecessary borrow scope, and instead replace the success/failure value with the casted/original value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://77684045