Fix some performance regressions [5.5] #37801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getParsedMembers() on imported and deserialized contexts has to pull in all the members. This is wasteful. Imported contexts do not have fingerprints at all, and fingerprints of deserialized contexts are serialized separately. The fast path handles these cases, only calling down to getParsedMembers() if the parent FileUnit is a SourceFile.
Check for the presence of a CustomAttr first, before calling into the request evaluator. Also clean up the logic a tiny bit.
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
slavapestov
changed the title
DougGregor
approved these changes
Jun 7, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://78880553.