Skip to content

Add AnyHashable support for Foundation.Decimal #3781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2016

Conversation

gribozavr
Copy link
Contributor

Add a custom AnyHashable representation to Foundation.Decimal, so that it behaves like all other bridged types.


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library only for macOS. Simulator standard libraries and
    device standard libraries are not built.
  3. lldb is not built.
  4. The test and validation-test targets are run only for macOS. The optimized
    version of these tests are not run.

A smoke test on Linux does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library incrementally.
  3. lldb is built incrementally.
  4. The swift test and validation-test targets are run. The optimized version of these
    tests are not run.
  5. lldb is tested.

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@gribozavr gribozavr changed the title Add AnyHashable support for Foundation.Decimal [Don't merge yet] Add AnyHashable support for Foundation.Decimal Jul 26, 2016
@gribozavr gribozavr force-pushed the stdlib-AnyHashable-for-Foundation.NSDecimalNumber branch from a65d86c to d76967d Compare July 26, 2016 21:36
@gribozavr gribozavr changed the title [Don't merge yet] Add AnyHashable support for Foundation.Decimal Add AnyHashable support for Foundation.Decimal Jul 26, 2016
@gribozavr
Copy link
Contributor Author

@swift-ci Please test

Add a custom AnyHashable representation to Foundation.Decimal, so that
it behaves like all other bridged types.
@gribozavr gribozavr force-pushed the stdlib-AnyHashable-for-Foundation.NSDecimalNumber branch from d76967d to ea693dd Compare July 27, 2016 08:14
@gribozavr
Copy link
Contributor Author

@swift-ci Please test and merge

@gribozavr
Copy link
Contributor Author

Tests passed, automatic merge failed. Merging manually.

@gribozavr gribozavr merged commit c0b183a into master Jul 27, 2016
@gribozavr gribozavr deleted the stdlib-AnyHashable-for-Foundation.NSDecimalNumber branch July 27, 2016 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant