runtime: annotate _environ DLL storage, exclude in WinRT
#37810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_environ` is meant to be DLL imported when linking against the C runtime dynamically (`/MD` or `/MDd`). However, when building for the Windows Runtime environment, we cannot support the use of `_environ` and thus disable the support for that. `_WINRT_DLL` identifies the combination of `/ZW` and `/LD` or `/LDd`. Windows Runtime builds cannot be executables (and obviously not static libraries as they are not executable), and thus we properly disable `ENVIRON` in all Windows Runtime builds.
|
CC: @mikeash |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_environis meant to be DLL imported when linking against the Cruntime dynamically (
/MDor/MDd). However, when building forthe Windows Runtime environment, we cannot support the use of
_environand thus disable the support for that.
_WINRT_DLLidentifies thecombination of
/ZWand/LDor/LDd. Windows Runtime builds cannotbe executables (and obviously not static libraries as they are not
executable), and thus we properly disable
ENVIRONin all WindowsRuntime builds.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.