[5.5] [SymbolGraph] add sourceOrigin info for all protocol implementations #37815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please build toolchain macOS platform |
|
Build failed |
QuietMisdreavus
changed the title
@swift-ci Please test macOS platform |
|
Ditto for the toolchain build. @swift-ci Please build toolchain macOS platform |
|
Toolchain build failed again in the SwiftPM tests: @swift-ci Please build toolchain macOS platform |
|
This is known issue, and it was resolved with this PR #37823 |
|
@swift-ci Please build toolchain macOS platform |
franklinsch
approved these changes
Jun 10, 2021
|
macOS Toolchain Install command |
airspeedswift
approved these changes
Jun 11, 2021
QuietMisdreavus
deleted the
QuietMisdreavus/5.5/sourceOrigin-with-feeling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://78680450
This PR ports #37777 to the
release/5.5branch.Change Information
sourceOrigininformation for symbols that implement protocol requirements when the protocol and the implementation are in the same module.sourceOriginfield in the symbol graph's relationships only appears when a symbol is synthesized, or when the protocol being implemented was defined in a different module. When a symbol is implementing a locally-defined protocol and also inherits docs, there is currently no way to relate the implementation to the symbol that defined the docs it's inheriting.