Revert "Revert "Revert "Disable module_deps_cache_reuse.swift test to unblock CI." and fix the test."" #37821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
nkcsgexi
approved these changes
Jun 7, 2021
|
@swift-ci please test |
compnerd
reviewed
Jun 12, 2021
| @@ -114,7 +111,7 @@ import SubE | |||
| // CHECK-NEXT: "-frontend" | |||
| // CHECK-NEXT: "-only-use-extra-clang-opts" | |||
| // CHECK-NEXT: "-Xcc" | |||
| // CHECK-NEXT: "clang" | |||
| // CHECK-NEXT: "{{.*}}clang" | |||
There was a problem hiding this comment.
Im not sure if this is the right thing to do - we really want to ensure that the correct clang is invoked (normally BUILD_DIR/clang).
… unblock CI." and fix the test.""
artemcm
force-pushed
the
RevertRevertRevertRevertCacheTest
branch
from
128ad50 to
61b704a
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
Build failed |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also make the test's pattern-matching of the problematic line a bit more robust.