[CMake] Disable swift-cmake tests if tools are not being built #37829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `swift-cmake` depends on `swift-syntax-generated-headers` which is only being built if the compiler (aka. `SWIFT_INCLUDE_TOOLS`) is being built. If a build only contains the stdlib, the test fails to configure. Disable it when `SWIFT_INCLUDE_TOOLS` is not set.
|
@swift-ci Please smoke test |
|
@ahoppen It actually doesn't depend on that. I was just cargo cutting some cmake code. This is meant to test the host swiftc. If there is a host swiftc then we should build/test this. |
|
I am fixing this in a different way here: #37838 |
|
OK, sounds good to me as well. Thanks for fixing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
swift-cmakedepends onswift-syntax-generated-headerswhich is only being built if the compiler (aka.SWIFT_INCLUDE_TOOLS) is being built. If a build only contains the stdlib, the test fails to configure. Disable it whenSWIFT_INCLUDE_TOOLSis not true.