Fix a debug info regression introduced with async support. #37844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci nominate |
|
This was actually caught by the modified inlined-generics testcase, but I didn't pay enough attention to that at the time, not realizing what problem this would cause in the backend. |
vedantk
approved these changes
Jun 9, 2021
This patch removes a heuristic to promote all debug intrinsics pointing into allocas to llvm.dbg.declare() intrinsics and instead more accurate classifies variables in async contexts by adding the missing cases alloc_box and alloc_stack cases. rdar://78977132
adrian-prantl
force-pushed
the
78977132-5.5
branch
from
5fda982 to
19203f2
Compare
|
@swift-ci test |
fredriss
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes a heuristic to promote all debug intrinsics pointing into
allocas to llvm.dbg.declare() intrinsics and instead more accurate classifies
variables in async contexts by adding the missing cases alloc_box and
alloc_stack cases.
rdar://78977132