AnyHashable tests for Foundation types: add tests for bridging back to Swift types + fixes that make tests pass #3785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test and merge |
|
Why is this not using a smoke test? Is a full test necessary? |
|
If I new this would pass the tests, I would not need to run them. |
gribozavr
force-pushed
the
Foundation-AnyHashable-tests
branch
from
abfe7b8 to
d4f364c
Compare
gribozavr
changed the title
|
These tests used to pass, but now master moved forward, and fixes by @jckarter are needed. Included them in this PR. |
|
@swift-ci Please test and merge |
gribozavr
force-pushed
the
Foundation-AnyHashable-tests
branch
from
d4f364c to
914ab4b
Compare
|
@swift-ci Please test and merge |
gribozavr
force-pushed
the
Foundation-AnyHashable-tests
branch
from
914ab4b to
4315082
Compare
|
@swift-ci Please test |
|
@swift-ci Please smoke test and merge |
|
OS X tests passed, Linux tests failed because of infrastructure reasons. @swift-ci Please test Linux platform |
|
OS X tests and Linux tests passed, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add another batch of tests for AnyHashable.
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.