[5.5][CodeCompletion] Keep completion status when parsing postfix types #37876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please nominate |
akyrtzi
approved these changes
Jun 25, 2021
e.g. optional type. rdar://78779049 (cherry picked from commit 6048d81)
rintaro
force-pushed
the
5.5-ide-completion-optionaltype-rdar78779049
branch
from
c8e66a6 to
d5ef83e
Compare
|
@swift-ci Please test |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #37874 into
release/5.5let _: (<HERE>)?didn't work if the completion happens outside function bodies. That was because, in parser, we didn't propagate the parser status to indicate a completion is happening