[Concurrency] Introduce TaskOptionRecord for spawn options #37885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmccall
reviewed
Jun 11, 2021
ktoso
commented
Jun 15, 2021
ktoso
commented
Jun 15, 2021
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS Platform |
|
@swift-ci please smoke test Linux Platform |
ktoso
force-pushed
the
wip-task-options
branch
2 times, most recently
from
0f6f6a1 to
bc32cda
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
DougGregor
approved these changes
Jun 17, 2021
|
@swift-ci please smoke test |
|
(macOS CI has a bad day, waiting it out for now) |
introduce new options parameter to all task spawning [Concurrency] ABI for asynclet start to accept options [Concurrency] fix unittest usages of changed task creation ABI [Concurrency] introduce constants for parameter indexes in ownership [Concurrency] fix test/SILOptimizer/closure_lifetime_fixup_concurrency.swift
|
@swift-ci please smoke test |
DougGregor
approved these changes
Jun 21, 2021
|
Force-merging to unblock progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress on adding
TaskOptionsRecordto all task creating and waiting.One such record can be "the executor to use for the spawn or resume" but we can add various new ones in the future.
Currently doing something incredibly silly somewhere where the signatures don't match up... I'll figure it out soon.