Skip to content

[SR-13239][Sema] Closure argument and result function call generic ambiguity #37896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

LucianoPAlmeida
Copy link
Contributor

Reopening #33122, where I mess up the rebase ... sorry it took some time to get back to this, but I think is now ready for review, so let me know what you think

Resolves SR-13239.

@LucianoPAlmeida LucianoPAlmeida requested review from xedin and hborla June 13, 2021 02:40
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is really promising, let's a couple of comments inline.

@LucianoPAlmeida LucianoPAlmeida force-pushed the SR-13239-closure-generic-ambiguity branch 2 times, most recently from 1d03fc2 to a893774 Compare June 15, 2021 23:47
@LucianoPAlmeida LucianoPAlmeida requested a review from xedin June 16, 2021 23:20
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@xedin
Copy link
Contributor

xedin commented Jun 17, 2021

@swift-ci please smoke test

@LucianoPAlmeida
Copy link
Contributor Author

@swift-ci please clean smoke test macOS platform

@LucianoPAlmeida LucianoPAlmeida force-pushed the SR-13239-closure-generic-ambiguity branch from a3d42fb to 0e8b7ce Compare June 18, 2021 13:56
@LucianoPAlmeida
Copy link
Contributor Author

@swift-ci Please smoke test

@LucianoPAlmeida
Copy link
Contributor Author

@swift-ci Please test Windows Platform

@LucianoPAlmeida
Copy link
Contributor Author

@swift-ci please clean smoke test macOS platform

@LucianoPAlmeida
Copy link
Contributor Author

@swift-ci Please clean smoke test macOS Platform

@LucianoPAlmeida
Copy link
Contributor Author

@swift-ci Please smoke test macOS Platform

@xedin
Copy link
Contributor

xedin commented Jun 22, 2021

@swift-ci please smoke test macOS platform

@LucianoPAlmeida LucianoPAlmeida merged commit dc0301d into swiftlang:main Jun 22, 2021
@LucianoPAlmeida LucianoPAlmeida deleted the SR-13239-closure-generic-ambiguity branch June 22, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants