Skip to content

[5.5][Refactoring] Support refactoring for case let patterns #37918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2021

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jun 15, 2021

  • Explanation: Previously we only supported case patterns that bound with a let inside the associated value like case .success(let value). With this change, we also support case let .success(value).
  • Scope: Async refactoring
  • Risk: Low
  • Testing: Added a test to the regression test suite
  • Issue: rdar://79279846
  • Reviewer: @hamishknight (Hamish Knight)

Previously we only supported `case` patterns that bound with a `let` inside the associated value like `case .success(let value)`. With this change, we also support `case let .success(value)`.

Fixes rdar://79279846 [SR-14772]
@ahoppen ahoppen added the r5.5 label Jun 15, 2021
@ahoppen ahoppen requested a review from airspeedswift June 15, 2021 14:23
@ahoppen ahoppen requested a review from a team as a code owner June 15, 2021 14:23
@ahoppen
Copy link
Member Author

ahoppen commented Jun 15, 2021

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - de925d1

@ahoppen
Copy link
Member Author

ahoppen commented Jun 16, 2021

@swift-ci Please test macOS

@ahoppen
Copy link
Member Author

ahoppen commented Jun 18, 2021

@swift-ci Please nominate

@ahoppen ahoppen merged commit c4c5e9b into swiftlang:release/5.5 Jun 19, 2021
@ahoppen ahoppen deleted the pr-5.5/case-let-refactoring branch June 21, 2021 08:03
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.5 labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants