Skip to content

[Concurrency] Reserve two more words in Job. #37919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Jun 15, 2021

Keep Task the same size by pulling two words out of OpaquePrivateStorage.

rdar://79313908

@mikeash mikeash requested a review from rjmccall June 15, 2021 14:52
Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mikeash
Copy link
Contributor Author

mikeash commented Jun 15, 2021

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 6d514c235d726839adddbc115fbb8cb87c682aad

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 6d514c235d726839adddbc115fbb8cb87c682aad

@mikeash mikeash force-pushed the reserve-more-job-storage branch from 6d514c2 to 0cca02d Compare June 15, 2021 21:44
@mikeash
Copy link
Contributor Author

mikeash commented Jun 15, 2021

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 0cca02d2d69a039349fcb25544fb7eb171ed57f9

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 0cca02d2d69a039349fcb25544fb7eb171ed57f9

@mikeash mikeash force-pushed the reserve-more-job-storage branch from 0cca02d to ebc37e6 Compare June 16, 2021 13:17
@mikeash
Copy link
Contributor Author

mikeash commented Jun 16, 2021

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ebc37e60c812c3503bbbcda2c6ec82f8686dbd73

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ebc37e60c812c3503bbbcda2c6ec82f8686dbd73

@mikeash mikeash force-pushed the reserve-more-job-storage branch 2 times, most recently from 7603acf to bd36409 Compare June 16, 2021 19:09
@mikeash
Copy link
Contributor Author

mikeash commented Jun 16, 2021

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - bd364099f38896188ab09ca36ba70ffe020cc65a

Keep Task the same size by pulling two words out of OpaquePrivateStorage.

rdar://79313908
@mikeash mikeash force-pushed the reserve-more-job-storage branch from bd36409 to c2df244 Compare June 16, 2021 20:59
@mikeash
Copy link
Contributor Author

mikeash commented Jun 16, 2021

@swift-ci please test

@mikeash mikeash merged commit 4cc1035 into swiftlang:main Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants