[5.5][CSBindings] Overload variable shouldn't be delayed by its application #37924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When inference is determining bindings of a type variable that represents an overload set (e.g. member or operator reference), let's not consider it as delayed due to presence of `ApplicableFunction` constraint since argument/result type inference depends on overload set but not vice versa. Resolves: rdar://78917861 (cherry picked from commit 81ff342)
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test Linux platform |
|
Build failed |
|
@swift-ci please clean test Linux platform |
tkremenek
approved these changes
Jun 17, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #37835
When inference is determining bindings of a type variable that represents
an overload set (e.g. member or operator reference), let's not consider
it as delayed due to presence of
ApplicableFunctionconstraint sinceargument/result type inference depends on overload set but not vice versa.
Scope: Some single-statement closure expressions that have contextual type that doesn't explicitly specify generic parameters.
Main Branch PR: [CSBindings] Overload variable shouldn't be delayed by its application #37835
Resolves: rdar://78917861
Risk: Low
Reviewed By: @hborla
Testing: Regression tests added to the suite
Resolves: rdar://78917861
(cherry picked from commit 81ff342)