[SE-0316] Introduce the GlobalActor protocol to describe global actors. #37930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the discussion in the first review of the global actors proposal, introduce a `GlobalActor` protocol that describes types that can be global actors. Introduce this protocol, make `@globalActor` types implicitly conform to it, and remove all of the bespoke validation logic that was used to check the "shared" member. Addresses rdar://79339591 (cherry picked from commit 8a068e0)
|
@swift-ci please test |
|
@swift-ci please nominate |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test Linux |
airspeedswift
approved these changes
Jun 16, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Based on the discussion of SE-0316, introduce a
GlobalActorprotocol that describes types that can be global actors.Scope: Affects the definition of global actors. The only one that currently exists is
MainActor.Radar/SR Issue: rdar://79339591
Risk: Very low.
Testing: PR testing and CI on main.
Original PR: #37917
Reviewed by: John McCall