[ConstraintSystem] Record produced types incrementally #37981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow type variable binding producer to record types as they are being produced. Otherwise it could be possible to re-discover already explored types during `computeNext()` which leads to duplicate bindings e.g. inferring fallback `Void` for a closure result type when `Void` was already inferred as a direct/transitive binding.
Make sure that `Void` doesn't get attempted twice if it was inferred directly or transitively.
hborla
approved these changes
Jun 21, 2021
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow type variable binding producer to record types as they
are being produced. Otherwise it could be possible to re-discover
already explored types during
computeNext()which leads toduplicate bindings e.g. inferring fallback
Voidfor a closureresult type when
Voidwas already inferred as a direct/transitivebinding.