[Parser] Allow closures with custom attributes and capture lists. #37987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parsing of Swift 1.0 beta-1 array syntax (e.g., `Int [something]`) was preventing closures with both a custom attribute (e.g., `@MainActor) and a capture list from parsing correctly. Don't parse that syntax within custom attributes. Fixes rdar://77303587.
|
@swift-ci please test |
|
@swift-ci please nominate |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test macOS |
|
Build failed |
|
@swift-ci please test macOS |
1 similar comment
|
@swift-ci please test macOS |
|
Build failed |
|
@swift-ci please test macOS |
tkremenek
approved these changes
Jun 24, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Parse closures with both a custom attribute (e.g.,
@MainActor) and a capture list without complaining about Swift 1.0 beta 1 array type syntax.Scope: Affects new code making use of concurrency.
Radar/SR Issue: rdar://77303587
Risk: Low.
Testing: PR testing and CI on main.
Original PR: #37986