[SR-4559] Warn when unapplied reference to a function 'self' is referenced in property initialiser #37992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackgmarch
changed the title
jackgmarch
changed the title
xedin
reviewed
Jun 21, 2021
jackgmarch
force-pushed
the
SR-4559
branch
3 times, most recently
from
2322a37 to
6175a3f
Compare
jackgmarch
force-pushed
the
SR-4559
branch
3 times, most recently
from
367d811 to
b681f1d
Compare
|
@swift-ci smoke test |
xedin
reviewed
Sep 1, 2021
…to method named "self" can be used without qualification) https://bugs.swift.org/browse/SR-4559
…n be used without qualification) https://bugs.swift.org/browse/SR-4559
|
@swift-ci smoke test |
@varungandhi-apple I'm assuming cause I pushed after you did the smoke test the smoke tests haven't run, guessing you need to start them again? thanks for starting them initially |
|
@swift-ci please smoke test |
|
Thank you, @jackgmarch! |
keith
added a commit
to keith/swift
that referenced
this pull request
Feb 23, 2022
swiftlang#37992 introduced a warning when you were likely to confuse `self` with `TypeName.self`, this also applied to enum cases that were named `self`, these cases should not be easily confused at call sites since their use requires prefixing them with a `.`. There was also no way to avoid this warning since other syntax such as `TypeName.self`, which produces the enum type instead, or `` TypeName`.self` `` which produced the same warning again. Fixes https://bugs.swift.org/browse/SR-15691
keith
added a commit
that referenced
this pull request
Feb 23, 2022
#37992 introduced a warning when you were likely to confuse `self` with `TypeName.self`, this also applied to enum cases that were named `self`, these cases should not be easily confused at call sites since their use requires prefixing them with a `.`. There was also no way to avoid this warning since other syntax such as `TypeName.self`, which produces the enum type instead, or `` TypeName.`self` `` which produced the same warning again. Fixes https://bugs.swift.org/browse/SR-15691
DougGregor
pushed a commit
that referenced
this pull request
Mar 23, 2022
#37992 introduced a warning when you were likely to confuse `self` with `TypeName.self`, this also applied to enum cases that were named `self`, these cases should not be easily confused at call sites since their use requires prefixing them with a `.`. There was also no way to avoid this warning since other syntax such as `TypeName.self`, which produces the enum type instead, or `` TypeName.`self` `` which produced the same warning again. Fixes https://bugs.swift.org/browse/SR-15691 (cherry picked from commit f6b2e2e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix to warn when unapplied references to a function called 'self' from are referenced unqualified from property initialisers.
Update: have fixed false positive referred to in strikethrough:
I'm having an issue though where my error message still shows when the reference is not unapplied. This is not allowed as it uses an instance method from a non-lazy initialiser, so there is no need for the error message I've added. Not sure how best to fix this as I'm brand new to Swift compiler contributions so any ideas would be much appreciated, I've already added a check for unapplied reference before showing the diagnostic. I'm assuming it technically is still treated as an unapplied reference because you can't call the function from a property initialiser, even though I have included the brackets to call it.Resolves #47136