Local functions can capture "self" as isolated. #38009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a short-term fix to address a regression in actor-isolation checking. A longer-term fix involves changing the way in which we model actor isolation so that local functions can be stated to be isolated to a particular capture, much like closures. This subsumes my short-sighted fix for "defer". Fixes rdar://79564012.
|
@swift-ci please test |
|
@swift-ci please nominate |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test macOS |
|
Build failed |
|
@swift-ci please test macOS |
|
Build failed |
|
@swift-ci please test macOS |
tkremenek
approved these changes
Jun 24, 2021
|
@swift-ci please test macOS |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Address a recent regression in actor-isolation checking that treated local functions within actor-isolated functions as non-isolated.
Scope: Only affects new code using actors and local functions.
Radar/SR Issue: rdar://79564012
Risk: Low.
Testing: PR testing and CI on main.
Original PR: #38010