Skip to content

[5.5] [ASTPrinter] Use TypeLoc printing for extended types. #38015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

varungandhi-apple
Copy link
Contributor

When the -module-interface-preserve-types-as-written flag is used,
the extended type should be printed similar to other types. The
checking for that flag happens in TypeLoc printing, not Type printing.
So we change extended type printing to use a TypeLoc instead.

Fixes rdar://79563937.

Cherry-pick #38014 to release/5.5.

@varungandhi-apple varungandhi-apple requested a review from a team as a code owner June 21, 2021 21:27
@varungandhi-apple
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 39eb220d1af140aa392b93b2b2b1551ccbbb7f71

@varungandhi-apple varungandhi-apple force-pushed the vg-5.5-interface-respect-flag branch from 39eb220 to ff65667 Compare June 21, 2021 22:19
When the -module-interface-preserve-types-as-written flag is used,
the extended type should be printed similar to other types. The
checking for that flag happens in TypeLoc printing, not Type printing.
So we change extended type printing to use a TypeLoc instead.

Fixes rdar://79563937.

(cherry picked from commit 284fcb5)
@varungandhi-apple varungandhi-apple force-pushed the vg-5.5-interface-respect-flag branch from ff65667 to c720c2c Compare June 21, 2021 23:20
@varungandhi-apple
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - c720c2c

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - c720c2c

@DougGregor
Copy link
Member

@swift-ci please test

@varungandhi-apple varungandhi-apple merged commit 4934207 into swiftlang:release/5.5 Jun 22, 2021
@varungandhi-apple varungandhi-apple deleted the vg-5.5-interface-respect-flag branch June 22, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants