Avoid an infinite recursion in modules which import themselves #3802
Conversation
|
@swift-ci Please smoke test. |
rjmccall
force-pushed
the
recursive-source-file-import-protection
branch
from
6225bb4 to
b2cf619
Compare
|
@swift-ci Please smoke test Linux. |
|
@swift-ci Please smoke test and merge. |
|
Apparently Michael G. has fixed the problem that was blocking the smoke testers. Let's try to placate the gods again. @swift-ci Please smoke test and merge. |
|
Ah. It failed because everything is still being gated. |
|
@rjmccall smoke test and merge is not working with the new setup yet. You have to do a plain smoke test for the status on github to be set correctly. Once that is done you should be able to merge yourself by hand (it worked for Joe an hour ago). Restarting the build. |
|
@swift-ci Please smoke test |
|
Ah, I can guess how that works. That doesn't look like my problem, so I'll try yet again. @swift-ci Please smoke test. |
|
Weird remote Java exception. Will try again later. |
|
@swift-ci Please smoke test. |
import themselves. It's not clear to me whether this situation is really intended, but this does fix build modules with this strange situation.
rjmccall
force-pushed
the
recursive-source-file-import-protection
branch
from
187e30d to
cfd9b83
Compare
|
@swift-ci Please smoke test |
What's in this pull request?
Resolved bug number: (SR-)
rdar://27571492
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
Protect the operator/precedencegroup lookup code against modules that import themselves.
It's not clear to me whether this situation is really intended, but
this does fix build modules with this strange situation.