[Parse] Don't skip '}' when recovering from 'default' outside 'switch' #38036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
ahoppen
approved these changes
Jun 23, 2021
| @@ -517,7 +517,7 @@ static ParserResult<Stmt> recoverFromInvalidCase(Parser &P) { | |||
| assert(P.Tok.is(tok::kw_case) || P.Tok.is(tok::kw_default) | |||
There was a problem hiding this comment.
I think you also need to adjust the doc comment consuming up to the next ':' or '}'
That caused assertion failures in code completion. rdar://78781163
rintaro
force-pushed
the
ide-completion-rdar78781163
branch
from
9a6a409 to
aa182ac
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That caused assertion failures in code completion.
rdar://78781163