[Serialization] Recover from deserialization failures in ModuleFile::lookupClassMembers
#38046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Access to a missing member on an AnyObject triggers a typo correction that looks at all class members in imported modules. Make sure it recovers from deserializing members referencing implementation-only imported types. rdar://79427805
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Jun 23, 2021
|
@swift-ci Please test Windows platform |
|
@swift-ci Please smoke test macOS |
|
@swift-ci Please test Windows platform |
artemcm
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code attempting to access a missing member on an
AnyObjecttriggers a typo correction that deserializes all class members in imported modules, even non-public ones. This change makes sure the compiler recovers from deserializing class members referencing implementation-only imported types.rdar://79427805