Ban classes from extending Actor and DistributedActor protocol explicitly
#38050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (bool)) | ||
|
|
||
| ERROR(actor_protocol_illegal_inheritance,none, | ||
| "illegal explicit inheritance from 'Actor' protocol, " |
There was a problem hiding this comment.
illegal is not a term I've seen thrown around in diagnostics, can we pick something less jarring? 😄
How about classes cannot declare a conformance to the 'Actor' protocol; declare this as %select{an actor|a distributed actor}0 instead?
There was a problem hiding this comment.
Thanks @harlanhaskins ! I was struggling with the right wording here.
@DougGregor suggested Non-actor type %0 cannot conform to the 'Actor' protocol how does that sound?
And there's a fixit to change struct->actor etc :)
ktoso
force-pushed
the
wip-ban-inherit-actor-protocols
branch
from
bf3a977 to
085a1a9
Compare
ktoso
changed the title
Actor and DistributedActor protocol explicitlyActor and DistributedActor protocol explicitly
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
|
Related to rdar://78975415 |
|
resolves rdar://79749091 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, some cleanup pending.