Skip to content

[5.5][IDE] Complete enum argument labels in unresolved member completions #38051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2021
Merged

[5.5][IDE] Complete enum argument labels in unresolved member completions #38051

merged 1 commit into from
Jun 25, 2021

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jun 23, 2021

  • Explanation: Previously, we weren’t suggesting argument labels of enum elements when doing an unresolved member completion. Treat EnumElementDecl similar to static AbstractFunctionDecls to show their argument labels.
  • Scope: Code completion inside references to enum elements
  • Risk: Low
  • Testing: Added regression test
  • Issue: rdar://78780690
  • Reviewer: @rintaro (Rintaro Ishizaki) on original PR [IDE] Complete enum argument labels in unresolved member completions #38000

@ahoppen
[IDE] Complete enum argument labels in unresolved member completions
d8a7b9e 
Previously, we weren’t suggesting argument labels of enum elements when doing an unresolved member completion. Treat `EnumElementDecl` similar to static `AbstractFunctionDecl`s to show their argument labels.

Fixes rdar://78780690 [SR-14689]
@ahoppen ahoppen added the r5.5 label Jun 23, 2021
@ahoppen ahoppen requested a review from airspeedswift June 23, 2021 12:40
@ahoppen ahoppen requested a review from a team as a code owner June 23, 2021 12:40
@ahoppen
Copy link
Member Author

ahoppen commented Jun 23, 2021

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Jun 23, 2021

@swift-ci Please nominate

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - d8a7b9e

@ahoppen
Copy link
Member Author

ahoppen commented Jun 24, 2021

@swift-ci Please test macOS

@ahoppen
Copy link
Member Author

ahoppen commented Jun 24, 2021

@swift-ci Please test Windows

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - d8a7b9e

@ahoppen
Copy link
Member Author

ahoppen commented Jun 24, 2021

macOS failure seems unrelated

@swift-ci Please test macOS

@ahoppen
Copy link
Member Author

ahoppen commented Jun 24, 2021

Windows failure seems unrelated

@swift-ci Please test Windows

@ahoppen
Copy link
Member Author

ahoppen commented Jun 25, 2021

Windows failure still unrelated

@swift-ci Please test Windows

@ahoppen ahoppen merged commit d572e13 into swiftlang:release/5.5 Jun 25, 2021
@ahoppen ahoppen deleted the pr-5.5/enum-unresolved-dot-arg-label branch June 25, 2021 10:36
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.5 labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkremenek tkremenek tkremenek approved these changes

@airspeedswift airspeedswift Awaiting requested review from airspeedswift

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahoppen @swift-ci @tkremenek @AnthonyLatsis