Skip to content

[5.5][CodeComplete] Mark results as not recommended if global actor context doesn't match #38056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jun 23, 2021

…t doesn't match

Annotate cross-actor references to global actors as `async` and mark them as not-recommended if they must be executed on a different actor than the current context is on.

Resolves rdar://75902598
@ahoppen ahoppen added the r5.5 label Jun 23, 2021
@ahoppen ahoppen requested a review from a team as a code owner June 23, 2021 16:55
@ahoppen
Copy link
Member Author

ahoppen commented Jun 23, 2021

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 441b8f6

@ahoppen
Copy link
Member Author

ahoppen commented Jun 24, 2021

@swift-ci Please test Linux

@ahoppen
Copy link
Member Author

ahoppen commented Jun 24, 2021

@swift-ci Please nominate

@akyrtzi akyrtzi merged commit 71938d7 into swiftlang:release/5.5 Jun 25, 2021
@ahoppen ahoppen deleted the pr-5.5/global-actor-completion branch June 25, 2021 06:38
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.5 labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants