[5.5][Sema] Use different solution vectors for ComponentSteps created by DependentComponentSplitterStep
#38061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `DependentComponentSplitterStep` Currently all `ComponentSteps` created by `DependentComponentSplitterStep` share the same `Solutions` vector. Because of this, the `ComponentStep`s might modify solutions created by previous `ComponentStep`s. Use different `Solutions` vectors for each `ComponentStep` to avoid sharing information between the `ComponentStep`s. The concrete manifestation in the added test case is that the `Bar` overload gets added to `Solutions`, it’s score gets reduced by its `ComponentStep` original score, then the `Foo` overload gets added to `Solutions` and both solutions have their score decreased by the `OriginalScore` of `Foo`’s `ComponentStep`, causing `Bar`’s score to underflow. Fixes rdar://78780840 [SR-14692]
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test Linux |
|
@swift-ci Please test Windows |
|
@swift-ci Please nominate |
DougGregor
approved these changes
Jun 24, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all
ComponentStepscreated byDependentComponentSplitterStepshare the sameSolutionsvector. Because of this, theComponentSteps might modify solutions created by previousComponentSteps. Use differentSolutionsvectors for eachComponentStepto avoid sharing information between theComponentSteps.For example, in the added test case the
qadding(bar:)overload gets added toSolutions, it’s score gets reduced by itsComponentSteporiginal score, then theqadding(foo:)overload gets added toSolutionsand both solutions have their score decreased by theOriginalScoreofqadding(foo:)’sComponentStep, causingqadding(bar:)’s score to underflow.ComponentSteps created byDependentComponentSplitterStep#37964