[SIL] Fix incorrect handling of 'forwarding' when parsing SIL

[mshockwave]

The forwarding directive should be optional for SIL instructions. However, the current SIL parser put it as a requirement when there is a comma follows after the main instruction components, which conflicts with debug info directives (if there is any) like loc or scope. This patch teaches the parser to treat forwarding as an optional directive.

Resolves SR-14814.

[mshockwave]

@swift-ci test

[adrian-prantl]

Could you also add a new test case that covers the changes?

[adrian-prantl]

Thanks!

[adrian-prantl]

@swift-ci test

[mshockwave]

Could you also add a new test case that covers the changes?

Sorry I forgot about the test. Currently I only add minimum amount of test that just covers SR-14814. Please let me know if I should add tests to cover every affected instruction types.

Also, I though the test should come with the fix so I amend the changes with the original commit instead of making a new one. Please let me know if that's improper

[adrian-prantl]

Could you also add a new test case that covers the changes?

Sorry I forgot about the test. Currently I only add minimum amount of test that just covers SR-14814. Please let me know if I should add tests to cover every affected instruction types.

I think most important is that we have coverage of the line with the if (P.consumeIf(tok::comma) && P.Tok.is(tok::identifier) && P.Tok.getText() == "forwarding") { logic that you changed, so the test looks good to me!

Also, I though the test should come with the fix so I amend the changes with the original commit instead of making a new one. Please let me know if that's improper

When making edits to address review feedback, we usually just amend the commit and git-push -f it, which I think is exactly what you did! Thanks for updating the PR so quickly.

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - e23157947e380e50d19c823320c94b70b02f871b

[mshockwave]

Make the test case more portable across 64/32-bit platforms.

[mshockwave]

@swift-ci test

[adrian-prantl]

@swift-ci test