🍒[5.5][Concurrency] Cancelled group should only spawn already cancelled tasks #38073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
ktoso
force-pushed
the
pick-wip-taskgroup-cancelled-async
branch
from
676df62 to
b8b839a
Compare
|
@swift-ci please test |
|
@swift-ci nominate |
DougGregor
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: When creating a child task from a cancelled task group, while the parent task is not cancelled, we still should be creating a cancelled child task. Not doing so causes confusion to end users and is not coherent with our own expectations. This change is ABI additive, it exposes the TaskGroup::isCancelled.
Reviewer: @DougGregor @rjmccall
Radar/SR Issue: rdar://79698889
Risk: Small.
Testing: PR testing and CI on main.
Original PR: #38072