Introduce fake symbols that were present with the old concurrency ABI. #38088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The concurrency ABI has shifted considerably, including renaming many symbols. However, there remain some existing libraries that link against these symbols and aren't necessarily immediately rebuilt. Add some "fake" symbols for the ones that we need, so those existing libraries can link against a new `_Concurrency` library... even though the resulting binary would not be able to execute. This is a grotesque hack and a stop-gap. Speculative fix for rdar://79298287.
|
@swift-ci please test |
|
@swift-ci please nominate |
|
Build failed |
|
@swift-ci please test Linux |
tkremenek
approved these changes
Jun 25, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Introduce some fake symbols that were present in the older concurrency ABI but are gone now, to prevent load-time failures for code that doesn't use concurrency but nonetheless still needs to run.
Scope: Only affects binaries build against older _Concurrency modules
Radar/SR Issue: rdar://79315034
Risk: Low.
Testing: PR testing and CI on main to avoid regressions for normal configurations; extensive testing of mismatched SDKs/compilers for the problem this is trying to solve.
Original PR: #38075, but that's not intended to be merged to
mainbecause this is a short-term hack.