[Swift next] Fixes for APInt::toString API changes #38110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The toString has been updated so that it doesn't return a std::string anymore. Instead, you have to pass the memory buffer in. This patch cleans that up.
Just went through and updated the rest of the APInt toString calls. This should take care of them, I hope.
etcwilde
commented
Jun 29, 2021
| Ty = cast<IntegerLiteralInst>(&SI)->getType(); | ||
| break; | ||
| case SILInstructionKind::FloatLiteralInst: | ||
| Str = cast<FloatLiteralInst>(&SI)->getBits().toString(16, | ||
| /*Signed*/false); | ||
| cast<IntegerLiteralInst>(&SI)->getValue().toString(Str, 16, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
APInt::toStringAPI changed and no longer has an overload to return astd::string.Instead, you have to pass the memory buffer in directly.
Also ran
git clang-formaton the commit, which had some fun with the include ordering. :)rdar://79746541