[Swift next] Construct DataLayout from string #38135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etcwilde
commented
Jun 29, 2021
include/swift/AST/TBDGenRequests.h
Outdated
| @@ -70,7 +70,7 @@ class TBDGenDescriptor final { | |||
| const TBDGenOptions &getOptions() const { return Opts; } | |||
| TBDGenOptions &getOptions() { return Opts; } | |||
|
|
|||
| const llvm::DataLayout &getDataLayout() const; | |||
| const llvm::DataLayout getDataLayout() const; | |||
There was a problem hiding this comment.
The TBDGenVisitor holds a reference to the data layout, which it gets from here.
This returns a temporary now, so that reference is invalid.
This patch fixes the call to get the datalayout from the clang module. Clang no longer holds onto the DataLayout object, so we have to do that if we want to keep it around. Rather than instanciating it early, we can just hold onto the string description, which clang does keep around, and only construct the actual DataLayout once we need it.
Same issue as with TBDGen. Clang doesn't hold onto the Datalayout object anymore, but instead keeps the description string that is constructed on the fly. This patch updates IRGen to behave the same way.
etcwilde
force-pushed
the
ewilde/swift-next/find-getDataLayout
branch
from
a87e8b8 to
b3422fe
Compare
|
I think we still have to hold onto the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang stopped returning the datalayout object, instead constructing it
on the fly from the string representation.
rdar://79799819