[5.5][build] Add the flags to enable cross-compiling the corelibs #38146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finagolfin
commented
Jun 29, 2021
| """ | ||
| CMake flags to build for a platform, useful for cross-compiling | ||
| """ | ||
| return '' |
There was a problem hiding this comment.
Since empty strings are passed here for every cross-compilation host but Android, this pull is very safe.
|
@drexin, would you run the CI on this? |
|
@swift-ci test |
|
Single concurrency test failure on Win CI appears unrelated. |
finagolfin
force-pushed
the
cross-compile
branch
from
122dae4 to
9ca6d68
Compare
|
Updated to include the test fix from #38181 and rebased. |
finagolfin
force-pushed
the
cross-compile
branch
from
9ca6d68 to
fb441eb
Compare
|
@drexin, would you run the CI on this again? |
|
@swift-ci test |
|
@swift-ci nominate |
Pass the Swift and CMake flags needed to cross-compile Foundation and so on, with the first example of Android. Add a new flag, --cross-compile-deps-path, which is used to search for cross-compiled libraries, like libcurl, that the corelibs depend on. Also add a new flag, --common-swift-flags, to pass additional Swift flags to the corelibs.
|
Rebased and given the further failures of this single test on trunk, #38279, made this test linux-only, as it is the only platform on which I have tested it myself. |
|
@swift-ci test |
|
@swift-ci nominate |
DougGregor
approved these changes
Jul 9, 2021
|
Thanks, everyone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #33724 and the test fix #38181
--cross-compile-hostsand currently does nothing for every cross-compilation host but Android.