Fix for a crash due to performLocalReleaseMotion and performLocalRetainMotion #38150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
meg-gupta
force-pushed
the
fixlowlevelarcassert
branch
from
89dd896 to
cbb2ad1
Compare
meg-gupta
changed the title
|
@swift-ci test |
|
Build failed |
|
Build failed |
atrick
requested changes
Jun 29, 2021
…inMotion In low level LLVMARCOptimizer, during canonicalization we don't rauw the result of RT_Retain with its arg similarly to RT_ObjCRetain and RT_BridgeRetain. And during performLocalReleaseMotion, we assert that we have canonicalized RT_Retain. In a release compiler, if we optimize such an RT_Retain with a RT_Release, then this can result in a compiler crash Similarly not rauw'ing, can cause a crash due to performLocalRetainMotion Fixes rdar://79238115
meg-gupta
force-pushed
the
fixlowlevelarcassert
branch
from
cbb2ad1 to
386cc23
Compare
|
@atrick The same issue can also happen with RT_UnknownObjectRetain. Fixed it. Thanks |
|
@swift-ci test |
|
Build failed |
|
@swift-ci test Linux Platform |
|
Build failed |
|
Trying again... @swift-ci test Linux Platform |
|
Build failed |
|
@swift-ci test Linux Platform |
|
Build failed |
|
Another flaky error. Trying again... @swift-ci smoke test Linux Platform |
|
@swift-ci clean smoke test Linux Platform |
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Jul 1, 2021
…inMotion (swiftlang#38150) In low level LLVMARCOptimizer, during canonicalization we don't rauw the result of RT_Retain with its arg similarly to RT_ObjCRetain and RT_BridgeRetain. And during performLocalReleaseMotion, we assert that we have canonicalized RT_Retain. In a release compiler, if we optimize such an RT_Retain with a RT_Release, then this can result in a compiler crash Similarly not rauw'ing, can cause a crash due to performLocalRetainMotion Fixes rdar://79238115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In low level LLVMARCOptimizer, during canonicalization we don't rauw the result of RT_Retain and RT_UnknownObjectRetain with its arg similarly to RT_ObjCRetain and RT_BridgeRetain.
And during performLocalReleaseMotion, we assert that we have canonicalized RT_Retain/RT_UnknownObjectRetain.
In a release compiler, if we optimize such an RT_Retain/RT_UnknownObjectRetain with a RT_Release/RT_UnknownObjectRelease, then this can result in a compiler crash
Similarly not rauw'ing, can cause a crash due to performLocalRetainMotion.
Note: This crash may only happen when LLVM fails to optimize these retain calls which are marked with
returnedattribute.Fixes rdar://79238115