Skip to content

[SR-14824] Improve diagnostic for multi-statement closures instead of… #38153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

JiarenWang
Copy link
Contributor

[SR-14824] Improve diagnostic for multi-statement closures instead of saying "too complex closure return type"

Resolves SR-14824.

@JiarenWang
Copy link
Contributor Author

@varungandhi-apple Pelease review.

@LucianoPAlmeida LucianoPAlmeida requested review from hborla and xedin June 29, 2021 12:04
@JiarenWang JiarenWang force-pushed the wjr branch 6 times, most recently from ed6c31c to 992a859 Compare June 30, 2021 06:25
@JiarenWang
Copy link
Contributor Author

@varungandhi-apple Pelease review.

Copy link
Contributor

@varungandhi-apple varungandhi-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. 👍🏼

@varungandhi-apple
Copy link
Contributor

@swift-ci smoke test and merge

Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@LucianoPAlmeida
Copy link
Contributor

@swift-ci Please smoke test MacOS Platform

@LucianoPAlmeida
Copy link
Contributor

@swift-ci Please test Windows Platform

@LucianoPAlmeida LucianoPAlmeida merged commit 7f08508 into swiftlang:main Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants