[5.5][CodeCompletion] Migrate key path completion to be solver based #38178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ahoppen
commented
Jun 30, 2021
ahoppen
commented
- Explanation: This migrates code completion inside key paths to the new solver-based implementation, using the solutions discovered by the type checker to infer the base on which to complete the next key path component. This fixes issues where code completion wasn’t working in key paths that had a generic base or result (which I believe is a very common case).
- Scope: Code completion inside key paths
- Risk: Low to medium (this is a fundamental change to how code completion inside key paths works but I feel confident that it’s correct since it’s using the same approach that we use for member completion)
- Testing: Added regression tests
- Issue: rdar://78779234 and rdar://78779335
- Reviewer: @xedin (Pavel Yaskevich) on original PR [CodeCompletion] Migrate key path completion to be solver based #38049
This commit essentially consistes of the following steps: - Add a new code completion key path component that represents the code completion token inside a key path. Previously, the key path would have an invalid component at the end if it contained a code completion token. - When type checking the key path, model the code completion token’s result type by a new type variable that is unrelated to the previous components (because the code completion token might resolve to anything). - Since the code completion token is now properly modelled in the constraint system, we can use the solver based code completion implementation and inspect any solution determined by the constraint solver. The base type for code completion is now the result type of the key path component that preceeds the code completion component. This resolves bugs where code completion was not working correctly if the key path’s type had a generic base or result type. It’s also nice to have moved another completion type over to the solver-based implementation. Resolves rdar://78779234 [SR-14685] and rdar://78779335 [SR-14703]
|
@swift-ci Please test |
akyrtzi
approved these changes
Jul 1, 2021
|
Windows failure is unrelated. |
This was referenced Jul 7, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.