Fix BorrowingOperand more. #38183
Fix BorrowingOperand more. #38183
Conversation
Don't allow an owned call argument to be considered a valid BorrowingOperand. More generally, make sure there is a perfect equivalence between valid BorrowingOperand and the corresponding OperandOwnership kind.
|
@swift-ci test |
| } | ||
| assert(kind != BorrowingOperandKind::Invalid && "missing case"); |
There was a problem hiding this comment.
With this can we now eliminate other kinds in BorrowingOperandKind: BeginApply, TryApply etc ?
There was a problem hiding this comment.
@meg-gupta A guaranteed apply argument is still considered a "Borrow" here. I think BorrowingOperand is useful for BeginApply because that's a scoped instruction, so it's important to call visitScopeEndingUses in that case.
I think it is a problem that BorrowingOperand is valid for Apply/TryApply/Yield, but visitScopeEndingUses does nothing there. That will lead to bugs where we miss the use completely. I'll see if it's easy to fix that in this PR too.
There was a problem hiding this comment.
Well, it looks like we're always careful before calling visitScopeEndUses to also visit the instruction that begins the scope too. So the behavior doesn't need to be changed, but I can add a comment in the next PR.
|
Build failed |
|
@swift-ci smoke test linux |
Don't allow an owned call argument to be considered a valid BorrowingOperand.
More generally, make sure there is a perfect equivalence between valid
BorrowingOperand and the corresponding OperandOwnership kind.