CSE: While optimizing lazy property getters, don't inline non-ossa to ossa function #38184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test source compatibility |
eeckstein
reviewed
Jul 1, 2021
… ossa function Fixes rdar://79781904
meg-gupta
force-pushed
the
fixcselazygetter
branch
from
81baedb to
f6c73a1
Compare
|
@swift-ci smoke test |
|
Windows build failure is unrelated to this change Failed Tests (1): Also full testing passed before I force pushed with an insignificant difference. Merging this. |
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Jul 2, 2021
…ssa to ossa function Fixes rdar://79781904 Cherry-pick of swiftlang#38184 • Explanation: Fixes a bug in optimizing lazy property getters in CSE. Lazy property getters are CSE'ed by inlining their function body. There was no check to skip inlining a non-ossa function into an ossa function which is illegal. • Scope of Issue: Can lead to crashes or miscompilations • Risk: Low. The fix is low risk because it is just avoiding the illegal CSE of lazy property getters. • Reviewed By: Erik Eckstein • Testing: Added unit tests
meg-gupta
added a commit
that referenced
this pull request
Jul 6, 2021
…ssa to ossa function (#38231) Fixes rdar://79781904 Cherry-pick of #38184 • Explanation: Fixes a bug in optimizing lazy property getters in CSE. Lazy property getters are CSE'ed by inlining their function body. There was no check to skip inlining a non-ossa function into an ossa function which is illegal. • Scope of Issue: Can lead to crashes or miscompilations • Risk: Low. The fix is low risk because it is just avoiding the illegal CSE of lazy property getters. • Reviewed By: Erik Eckstein • Testing: Added unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://79781904