[5.5] Fix SILGen of access to isolated static properties #38190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When accessing a static property isolated to a global-actor, such as MainActor, a `hop_to_executor` was not being emitted. This was caught by an assertion I had left to catch such cases, but of course in release builds this will lead to incorrect SIL, etc. This issue revealed some other problems with how the implementation was done for other kinds of accesses starting from a static property, e.g., emitting a redundant hop for the same access. This was fixed by modelling the actor-isolation placed into a component as only being accessible by consuming it from the component. This prevents the emission of the hops more than once. Thus, the regression test was updated to catch unexpected hop_to_executor instructions. Resolves rdar://78292384
Added an implicit CHECK-NOT to catch any unexpected hop_to_executor instructions in the output of SILGen.
kavon
added
bug
|
@swift-ci please test |
ktoso
approved these changes
Jul 1, 2021
|
Build failed |
|
@swift-ci please test Linux platform |
|
@swift-ci please nominate |
DougGregor
approved these changes
Jul 1, 2021
|
Build failed |
|
@swift-ci please clean test and merge |
|
@swift-ci please clean test linux platform |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Accesses to actor-isolated static properties, such as those isolated to the MainActor, were being miscompiled, which led to missing synchronization and "hopping" to the main thread.
Risk: Low.
Original PRs: #38114
Radar/SR Issue: rdar://78292384
Reviewed By: Konrad Malawski
Testing: Regression tests are included