[Demangler] Prevent stack overflow by limiting recursion depth. #38192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
It's trivially easy to drive the remanglers, the type decoder and the node printer into a situation where they will overflow the process's stack. For the compiler, this is fine (though not great), but for the runtime it's a no-no. This changeset imposes recursion depth limits to prevent uncontrolled stack overruns. rdar://68449341
al45tair
force-pushed
the
problem/68449341
branch
from
62d3d8d to
8f717d2
Compare
|
@swift-ci Please smoke test |
mikeash
approved these changes
Jul 1, 2021
|
@al45tair - this seems to have regressed the Windows builds as indicated by the CI |
|
@compnerd Apologies. I should have spotted that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's trivially easy to drive the remanglers, the type decoder and the node printer into a situation where they will overflow the process's stack. For the compiler, this is fine (though not great), but for the runtime it's a no-no.
This changeset imposes recursion depth limits to prevent uncontrolled stack overruns.
rdar://68449341