[Reflection] Fix iterateAsyncTaskAllocations. #38203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeash
force-pushed
the
fix-iterate-async-task-allocations
branch
from
cc9df8b to
f0e41d7
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
mikeash
force-pushed
the
fix-iterate-async-task-allocations
branch
from
f0e41d7 to
4e5655a
Compare
|
@swift-ci please test |
mikeash
force-pushed
the
fix-iterate-async-task-allocations
branch
from
4e5655a to
56d8c31
Compare
|
@swift-ci please test |
Fix the declaration of AsyncTask and add a test for iterateAsyncTaskAllocations. Reflection's declaration of AsyncTask had fallen out of sync with the real thing. The test that was supposed to catch this was never actually committed, oops. Add a swift_reflection_libraryVersion variable to Remote Mirror to indicate the presence of this fix. In the future, the value can be incremented to signal the presence of other changes that can't otherwise be detected. rdar://80035307
mikeash
force-pushed
the
fix-iterate-async-task-allocations
branch
from
56d8c31 to
c0e6e1d
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the declaration of AsyncTask and add a test for iterateAsyncTaskAllocations. Reflection's declaration of AsyncTask had fallen out of sync with the real thing. The test that was supposed to catch this was never actually committed, oops.
rdar://80035307