GSB: Don't forget to concretize conformances when processing a same-type requirement [5.5] #38208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype requirement When merging two type parameters T1 and T2, if T2 had a concrete type and T1 had conformance requirements, we did not "concretize" the conformances. As a result, the conformance requirements were not marked as redundant, which would cause a crash (no assert build) or assertion failure (in an assert build) later on inside rebuildSignatureWithoutRedundantRequirements(). Fixes rdar://problem/79570734.
slavapestov
force-pushed
the
gsb-concrete-conformance-fix-5.5
branch
from
c66f85c to
a7a38d6
Compare
|
@swift-ci Please test |
DougGregor
approved these changes
Jul 1, 2021
|
Build failed |
|
This is the 5.5 cherry-pick of #38207. |
|
Linux failure is unrelated: |
|
@swift-ci Please test Linux |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging two type parameters T1 and T2, if T2 had a concrete type
and T1 had conformance requirements, we did not "concretize" the
conformances.
As a result, the conformance requirements were not marked as redundant,
which would cause a crash (no assert build) or assertion failure (in an
assert build) later on inside rebuildSignatureWithoutRedundantRequirements().
Fixes rdar://problem/79570734.