Skip to content

[5.5][Sema] Properly handle missing coding keys in enum Codable synthesis #38216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2021
Merged

[5.5][Sema] Properly handle missing coding keys in enum Codable synthesis #38216

merged 1 commit into from
Jul 2, 2021

Conversation

drexin
Copy link
Contributor

@drexin drexin commented Jul 2, 2021 •
edited
Loading

  • Explanation: We were missing a check for the case where a custom CodingKeys enum is defined and is missing a key for an existing case. It is allowed to do that, but because of the missing check, we ran into a segfault.
  • Scope: Enum codable synthesis
  • Main Branch PR: [Sema] Properly handle missing coding keys in enum Codable synthesis #38210
  • Issue: rdar://79671408
  • Risk: Low
  • Reviewed By: @ktoso
  • Testing: added regression tests

@drexin drexin requested a review from a team as a code owner July 2, 2021 00:20
@drexin
Copy link
Contributor Author

drexin commented Jul 2, 2021

@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented Jul 2, 2021

Build failed
Swift Test Linux Platform
Git Sha - 394c191

@drexin
Copy link
Contributor Author

drexin commented Jul 2, 2021

@swift-ci test linux

@drexin
Copy link
Contributor Author

drexin commented Jul 2, 2021

@swift-ci nominate

@ktoso ktoso added the r5.5 label Jul 2, 2021
@DougGregor DougGregor merged commit f35042a into swiftlang:release/5.5 Jul 2, 2021
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.5 labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@drexin @swift-ci @ktoso @DougGregor @AnthonyLatsis