[IRGen][DebugInfo] Use attached SILLocation for generating debug location for variable declaration #38233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
eeckstein
approved these changes
Jul 6, 2021
adrian-prantl
approved these changes
Jul 6, 2021
Currently IRGen requires the AST node of a variable declaration to generate debug location. However, this will fail if the input is SIL due to the lack of AST reconstruction. Plus, it's unnecessary since we can just use the `SILLocation` attached on `debug_value` (and its friends) SIL instruction to generate the correct LLVM debug metadata. Resolves SR-14868
mshockwave
force-pushed
the
dev-irgen-dbg-val-improve
branch
from
95ca904 to
2d35d31
Compare
|
@swift-ci test |
|
Build failed |
|
@swift-ci test |
|
Previously Linux fail with "outdated module cache" error, which I think it's irrelevant to this PR, and now Mac OS X failed with some filesystem issue. Guess I need to launch again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently IRGen requires the AST node of a variable declaration to generate debug location. However, this will fail if the input is SIL due to the lack of AST reconstruction. Plus, it's unnecessary since we can just use the
SILLocationattached ondebug_value(and its friends) SIL instruction to generate the correct LLVM debug metadata. This patch implement the said solution.Resolves SR-14868