Skip to content

[5.5][Sema] Revert temporary downgrade of diagnostic on misplaced unownedExecutor #38234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2021
Merged

[5.5][Sema] Revert temporary downgrade of diagnostic on misplaced unownedExecutor #38234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions include/swift/AST/DiagnosticsSema.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4370,10 +4370,7 @@ ERROR(actor_protocol_illegal_inheritance,none,
"non-actor type %0 cannot conform to the 'Actor' protocol",
(DeclName))

// FIXME: This diagnostic was temporarily downgraded from an error because
// it spuriously triggers when building the Foundation module from its textual
// swiftinterface. (rdar://78932296)
WARNING(unowned_executor_outside_actor,none,
ERROR(unowned_executor_outside_actor,none,
"'unownedExecutor' can only be implemented within the main "
"definition of an actor", ())
ERROR(override_implicit_unowned_executor,none,
Expand Down
5 changes: 1 addition & 4 deletions lib/Sema/TypeCheckProtocol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4584,10 +4584,7 @@ void ConformanceChecker::resolveValueWitnesses() {
Adoptee->getClassOrBoundGenericClass() &&
Adoptee->getClassOrBoundGenericClass()->isActor()) {
witness->diagnose(diag::unowned_executor_outside_actor);
// FIXME: This diagnostic was temporarily downgraded from an error to a
// warning because it spuriously triggers when building the Foundation
// module from its textual swiftinterface. (rdar://78932296)
//return;
return;
}

// Objective-C checking for @objc requirements.
Expand Down