[5.5][ConstraintSystem] Bind missing member in pattern match to a hole early #38236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If lookup failed to find a member for a pattern match, let's bind type variable representing such member to a hole right away, otherwise there is a risk of missing other potential hole locations in pattern function type (arguments + result type) because pattern matching doesn't use 'applicable function' constraint. Resolves: rdar://65667992 (cherry picked from commit c1d0036)
|
@swift-ci please clean test |
|
@swift-ci please nominate |
DougGregor
approved these changes
Jul 6, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #38199
If lookup failed to find a member for a pattern match, let's bind
type variable representing such member to a hole right away, otherwise
there is a risk of missing other potential hole locations in pattern
function type (arguments + result type) because pattern matching
doesn't use 'applicable function' constraint.
Scope: pattern matching incorrect members (nonexistent or misspelled name) in case statements.
Main Branch PR: [ConstraintSystem] Bind missing member in pattern match to a hole early #38199
Resolves: rdar://65667992
Risk: Low
Reviewed By: @hborla
Testing: Regression tests added to the suite
Resolves: rdar://65667992
(cherry picked from commit c1d0036)