Skip to content

[build] don't run strip for libclang_rt.tvossim.a #38237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[build] don't run strip for libclang_rt.tvossim.a #38237

wants to merge 2 commits into from

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Jul 2, 2021

  1. strip will fail parsing that in Xcode 13.0b1
  2. that library is copied from the Xcode installation
    and it is already stripped

Addresses rdar://80098850

@edymtt
[build] don't run strip for libclang_rt.tvossim.a
b4b7661 
1) strip will fail parsing that in Xcode 13.0b1
2) that library is copied from the Xcode installation
and it is already stripped

Addresses rdar://80098850
@edymtt edymtt requested review from gottesmm and shahmishal July 2, 2021 20:06
@edymtt
Copy link
Contributor Author

edymtt commented Jul 2, 2021

@swift-ci please build toolchain

@edymtt
Copy link
Contributor Author

edymtt commented Jul 2, 2021

@swift-ci please smoke test

@edymtt edymtt requested a review from hyp July 2, 2021 20:09
@edymtt
Copy link
Contributor Author

edymtt commented Jul 2, 2021

@swift-ci please build toolchain

@edymtt
Copy link
Contributor Author

edymtt commented Jul 2, 2021

@swift-ci please smoke test

@swift-ci
Copy link
Contributor

swift-ci commented Jul 2, 2021

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 653e9f2

Install command
tar zxf swift-PR-38237-618-ubuntu16.04.tar.gz
More info

@edymtt
Copy link
Contributor Author

edymtt commented Jul 2, 2021

@swift-ci please smoke test Linux

@edymtt
Copy link
Contributor Author

edymtt commented Jul 5, 2021

The testing highlighted two issues

  • my change was wrong
  • the error does also happen with Xcode 12.3, not only with 13.0b1

After a bit more investigation, I realized this was the same issue tackled in #34361

I will be reintroducing the same solution as part of #38262
and closing this one

@edymtt edymtt closed this Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahmishal shahmishal shahmishal approved these changes

@gottesmm gottesmm Awaiting requested review from gottesmm

@hyp hyp Awaiting requested review from hyp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edymtt @swift-ci @shahmishal