Fixed some common grammatical errors in the comments. #38248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made some grammatical changes and removed some common spelling mistakes.
xedin
reviewed
Jul 3, 2021
xedin
reviewed
Jul 4, 2021
| @@ -579,7 +580,6 @@ static bool tryDominatorBasedSimplifications( | |||
| } | |||
| return Changed; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Could you please this newline back?
| @@ -107,6 +107,7 @@ class SimplifyCFG { | |||
| bool ShouldVerify; | |||
| bool EnableJumpThread; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
No need for this newline here
Thank you @xedin, I removed the extra newlines. Please let me know if there's anything else I need to do. |
xedin
approved these changes
Jul 4, 2021
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
xwu
reviewed
Jul 27, 2021
| @@ -2054,7 +2054,7 @@ static bool hasSameUltimateSuccessor(SILBasicBlock *noneBB, SILBasicBlock *someB | |||
|
|
|||
| // Otherwise, lets begin a traversal along the successors of noneSuccessorBB, | |||
| // searching for someSuccessorBB, being careful to only allow for blocks to be | |||
| // visited once. This enables us to guarantee that there are not any loops or | |||
| // visited once. This enables us to guarantee that there no loops or | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some common grammatical mistakes found in the comments of some files.